NREL / ComStock

National scale modeling of the U.S. commercial building stock supported by U.S. DOE, LADWP, and others and maintained by NREL
Other
31 stars 9 forks source link

Handle OpenStudio v3.7.0 deprecated methods #140

Closed eringold closed 7 months ago

eringold commented 7 months ago

There are a couple measures that call deprecated methods openstudio::model::AirLoopHVACUnitarySystem::setSupplyAirFlowRateMethodDuringCoolingOperation and openstudio::model::AirLoopHVACUnitarySystem::setSupplyAirFlowRateMethodDuringHeatingOperation.

E.g.: https://github.com/NREL/ComStock/blob/71597058f9077c77d3c3fc6ae2d38c1c91e74034/resources/measures/hardsize_model/measure.rb#L142-L143 and https://github.com/NREL/ComStock/blob/71597058f9077c77d3c3fc6ae2d38c1c91e74034/resources/measures/upgrade_hvac_doas_hp_minisplits/measure.rb#L1353-L1360

Example of how to handle these: https://github.com/NREL/ComStock/blob/71597058f9077c77d3c3fc6ae2d38c1c91e74034/resources/measures/upgrade_hvac_console_gshp/measure.rb#L414-L422

Might want to also check for any others.