[X] Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
[x] Added tests for new measures
[X] Updated measure .xml(s)
[x] Register values added to comstock_column_definitions.csv
[x] Both options_lookup.tsv files updated
[ ] 10k+ test run
[ ] Change documentation written
[X] Measure documentation written
[ ] ComStock documentation updated
[ ] Changes reflected in example .yml files
[x] Changes reflected in README.md files
[ ] Added 'See ComStock License' language to first two lines of each code file
[ ] Implements corresponding measure tests and indexing path in test/measure_tests.txt or/and test/resource_measure_tests.txt
[ ] All new and existing tests pass the CI
Review Checklist
This will not be exhaustively relevant to every PR.
[ ] Perform a code review on GitHub
[ ] All related changes have been implemented: data and method additions, changes, tests
[ ] If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
[ ] Reviewed change documentation
[ ] Ensured code files contain License reference
[ ] Results differences are reasonable
[ ] Make sure the newly added measures has been added with tests and indexed properly
Pull request overview
This became a very complicated change including multiple sub-PRs and multiple updates on the same thing. But below are the summary of changes:
upgrade_hvac_add_heat_pump_rtu
measure (and corresponding unit tests) refactored and updatedcomstock_sensitivity_reports
measure updated to include cycling impactsthese sub-PRs include some major context of the changes
this PR also includes some other stuffs:
create_
measure update to 3.8, os stds update to 0.6.1, and maybe more...updated some shared/test models to 3.8
I couldn't avoid including these other xml updates. sorry.
Pull Request Author
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csv
options_lookup.tsv
files updated.yml
filesREADME.md
filestest/measure_tests.txt
or/andtest/resource_measure_tests.txt
Review Checklist
This will not be exhaustively relevant to every PR.