NREL / ComStock

National scale modeling of the U.S. commercial building stock supported by U.S. DOE, LADWP, and others and maintained by NREL
Other
29 stars 7 forks source link

Use serial update for each upgrades data frame #186

Closed wenyikuang closed 1 day ago

wenyikuang commented 2 months ago

Pull request overview

This PR is intended to fix the https://github.com/NREL/ComStock/issues/149 .

How do I test it works?

With cycle3_euss_10k_df_2 dataset and there are 3 upgrades. I confirmed the results in output parquets are matching without the change. With cycle3_euss_full_350k_combined dataset and there are 32 upgrades. I could finished the run in my local laptop.

This pull request makes changes to (select all the apply):

Author pull request checklist:

Review Checklist

This will not be exhaustively relevant to every PR.

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

TODO:

rHorsey commented 3 days ago

This now also includes sampling v2. I'm pulling in changes directly here.

rHorsey commented 3 days ago

@ChristopherCaradonna This is the branch to test the 10k with! I haven't merged main into this however, so I'm unsure if there are conflicts esp w/ options lookup.

rHorsey commented 1 day ago

Big (and somewhat breaking) merge to speed work towards Nov EUSS Release with new sampling and much better postprocessing. Huge thanks @wenyikuang !!!