Closed ChristopherCaradonna closed 2 months ago
@ChristopherCaradonna
I'm seeing changes not related to fans. Based on your branch history, looks like you merged your timeseries plot branch to develop and then made changes to fans? I don't think that a good practice... but was that the intent? Are you not planning to do a separate PR for your timeseries plots? Tracking wise, I think it'd be better to merge the timeseries plot stuff first to develop
, rebase both of yours and my branch to the new develop
, and then merge this PR which will only include changes for fans.
change seems simple and reasonable!!
Pull request overview
Sets fan total efficiency of "standard efficiency" HP RTU measure to use code values. Also changes to fan curve coefficients such they the power multiplier is 1 at a flow fraction of 1.
Pull Request Author: Chris CaraDonna
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csv
options_lookup.tsv
files updated.yml
filesREADME.md
filestest/measure_tests.txt
or/andtest/resource_measure_tests.txt
Review Checklist
This will not be exhaustively relevant to every PR.
ComStock Licensing Language - Add to Beginning of Each Code File