Closed mdahlhausen closed 1 week ago
These changes look good. Do you intend to update/refactor ChangeBuildingLocation in a separate PR?
Yes, in a separate PR. The buildstock weather .stat files miss a lot of the information necessary for the weather methods in standards. I'll need to make some smart defaults or adjustments, and alternative calculation pathways to determine things like design day criteria.
These changes look good. Do you intend to update/refactor ChangeBuildingLocation in a separate PR?
Yes, in a separate PR. The buildstock weather .stat files miss a lot of the information necessary for the weather methods in standards. I'll need to make some smart defaults or adjustments, and alternative calculation pathways to determine things like design day criteria.
@carlobianchi89 may have some insight here
These changes look good. Do you intend to update/refactor ChangeBuildingLocation in a separate PR?
Yes, in a separate PR. The buildstock weather .stat files miss a lot of the information necessary for the weather methods in standards. I'll need to make some smart defaults or adjustments, and alternative calculation pathways to determine things like design day criteria.
@carlobianchi89 may have some insight here
We could regenerate the ComStock data files to include more information in the .stat file. But since many of the fields are calculated from the .epw, it may make sense to just have a method to calculate them. Things like design days, degree days, and ground temperatures.
I do know there needs to be more error checking on the weather files anyways. So perhaps an opportunity to add content to the .stat files too. Dru Crawley and One Building have code to calculate that information.
Pull request overview
This PR updates ComStock to use the latest version of openstudio-standards (0.6.2 interm release)
Pull Request Author
This pull request makes changes to (select all the apply):
Author pull request checklist:
.yml
filesREADME.md
filesReview Checklist
This will not be exhaustively relevant to every PR.
ComStock Licensing Language - Add to Beginning of Each Code File