openstudio-standards update

mdahlhausen commented 1 month ago

Pull request overview

This PR updates ComStock to use the latest version of openstudio-standards (0.6.2 interm release)

Fixes #60 and #172

Pull Request Author

This pull request makes changes to (select all the apply):

[ ] Documentation
[x] Infrastructure (includes apptainer image, buildstock batch, dependencies, continuous integration tests)
[ ] Sampling
[x] Workflow Measures
[x] Upgrade Measures
[x] Reporting Measures
[ ] Postprocessing

Author pull request checklist:

[x] Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
[x] Added tests for new measures
[x] Updated measure .xml(s)
[x] 10k+ test run
[x] Change documentation written
[x] ComStock documentation updated
[x] Changes reflected in example .yml files
[x] Changes reflected in README.md files
[x] Added 'See ComStock License' language to first two lines of each code file
[ ] All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

[x] Perform a code review on GitHub
[x] All related changes have been implemented: data and method additions, changes, tests
[x] If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
[x] Reviewed change documentation
[x] Ensured code files contain License reference
[x] Results differences are reasonable
[x] Make sure the newly added measures has been added with tests and indexed properly
[x] CI status: all tests pass

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

mdahlhausen commented 4 weeks ago

These changes look good. Do you intend to update/refactor ChangeBuildingLocation in a separate PR?

Yes, in a separate PR. The buildstock weather .stat files miss a lot of the information necessary for the weather methods in standards. I'll need to make some smart defaults or adjustments, and alternative calculation pathways to determine things like design day criteria.

bonnema commented 4 weeks ago

These changes look good. Do you intend to update/refactor ChangeBuildingLocation in a separate PR?

Yes, in a separate PR. The buildstock weather .stat files miss a lot of the information necessary for the weather methods in standards. I'll need to make some smart defaults or adjustments, and alternative calculation pathways to determine things like design day criteria.

@carlobianchi89 may have some insight here

mdahlhausen commented 3 weeks ago

These changes look good. Do you intend to update/refactor ChangeBuildingLocation in a separate PR?

Yes, in a separate PR. The buildstock weather .stat files miss a lot of the information necessary for the weather methods in standards. I'll need to make some smart defaults or adjustments, and alternative calculation pathways to determine things like design day criteria.

@carlobianchi89 may have some insight here

We could regenerate the ComStock data files to include more information in the .stat file. But since many of the fields are calculated from the .epw, it may make sense to just have a method to calculate them. Things like design days, degree days, and ground temperatures.

I do know there needs to be more error checking on the weather files anyways. So perhaps an opportunity to add content to the .stat files too. Dru Crawley and One Building have code to calculate that information.

NREL / ComStock