NREL / ComStock

National scale modeling of the U.S. commercial building stock supported by U.S. DOE, LADWP, and others and maintained by NREL
Other
31 stars 10 forks source link

Rhorsey/sampling v2 plotting patch #217

Closed rHorsey closed 2 months ago

rHorsey commented 2 months ago

Pull request overview

Updates plotting scripts for comparing upgrades, baselines, and CBECS. AMI and Timeseries are up next - EIA requires a transition to our current postproc paradigm.

Pull Request Author

This pull request makes changes to (select all the apply):

Author pull request checklist:

Review Checklist

This will not be exhaustively relevant to every PR.

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.
rHorsey commented 2 months ago

Thanks @wenyikuang - updated the paths and also switched to using Resource instead of Client in boto3 to avoid an error with the policy on stuff uploaded from Kestrel using the default upload policy.

rHorsey commented 2 months ago

@ChristopherCaradonna can you delete the lighting upgrade in you comstock_data and try rerunning compare_upgrades again? If that works as expected can you review / approve please?

rHorsey commented 2 months ago

@ChristopherCaradonna 's issues addressed - ready for approval! Great catch on mid-atlantic - many thanks!.