Open JieXiong9119 opened 2 days ago
@JieXiong9119 for processing the 2024 Release 2 SDR dataset we are making changes on this branch: https://github.com/NREL/ComStock/tree/wenyi/euss_r3, so please change the target branch of this PR to point to that instead of main. I already added the 15 daily_average_electricity_ghg_emissions
columns back to that branch. Also, adding 215 calculated columns to all the public files is too many because these variables are not likely to be used by most people, so we can keep them in the column_definitions.csv and keep the code which creates them, but change the export options to FALSE, FALSE so that they don't end up in the public dataset. If you want to run postprocessing separately yourself with them set to TRUE, FALSE that's fine.
Pull request overview
This PR is to implement and register multiple output variables related to peak load and emission data, regarding calculated intensity and savings (and percent savings), and write to comstockwide csv in the postprocessing workflow. Changes take place in
Changes I did not make that might be relavent:
add_normalized_qoi_columns
calculating for a few peak load variables remains untouched, due to unit scale difference (w/ft2 in existing function, but kw/ft2 in added function)Pull Request Author
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csv
options_lookup.tsv
files updated.yml
filesREADME.md
filestest/reporting_measure_tests.txt
,test/workflow_measure_tests.txt
, ortest/upgrade_measure_tests.txt
Review Checklist
This will not be exhaustively relevant to every PR.
ComStock Licensing Language - Add to Beginning of Each Code File