Updates toward release

[Myoldmopar]

FYI @JasonGlazer

Enormous set of changes, but at this point I have it cleanly building and posting to PyPi. I have coverage back up to 100%, and Flake8 all happy. I'd like to show it off and discuss it with you as the functionality is almost all in place, but there are certainly some little tweaks to make before merge.

[Myoldmopar]

Some things I'd like to wrap up before merge:

• [x] Verify/cleanup the recent weather operations
• [x] Add favorite folders
• [x] Redo group recent operations
• [x] Change config file name
• [x] Delete old frame file
• [x] Cleanup main frame.py code -- try to extract functionality into worker code that can be easily tested
• [x] Can we use None for design-day-only rather than the magic string "no-weather-file"? Later
• [x] Change instantiate_all_workflow operation to return something better than warning text
• [x] Check the output file dropdown operation, is it OK?
• [x] Version capabilities should be available in the workflow base class, workflows shouldn't import other EPLaunch stuff
• [x] Evaluate energyplus.py workflow file structure -- odd...
• [x] Modify E+ workflows to fallback between eplaunch and energyplus_launch

[Myoldmopar]

@JasonGlazer OK, this is ready for review. The best way will be to just show off the tool on a meeting so I'll reach out to you separately to set that up.

This should be equivalent or very very close to the wx version, but with a much improved packaging/deployment experience. I have pip installed it on all three platforms and it behaves perfectly and look good on all of them.

[Myoldmopar]

Noticed there is something up with the weather file path. It will try to find the weather file in the current working directory, at least sometimes. Need to scan the code to protect against that. I will make a full pass over the code looking for other things to protect while I'm in there.

[Myoldmopar]

OK, looks like the weather file issue was just due to something that is already fixed in the code. At some point we were only keeping the weather file name in the cache, but it's always a full path or the "" key to indicate design days. I don't think that's an issue now, so moving on from that. Some final tasks here include:

• Something is failing to release the audit file when E+ is done, which is causing workflows to fail. I'm not sure if it's inside E+, or in the E+ workflow, but either way I don't think it's anything related to EPLaunch.
• Taskbar icons are not working right on Windows. I thought I had this solved, but it seems not. I'm doing things the exact same way as I do for other tools like the regression tool, but for some reason it doesn't work for EPLaunch.

[Myoldmopar]

Audit file issue appears to be inside E+ itself. I could reproduce the issue easily, just run the same file twice in a row. I then went into the E+ code and tried manually closing a chunk of files inside CloseOutputFiles, and built a new package. When I run that in EPLaunch, it can run as many times as it wants successfully. The file descriptors are simply being held on Windows for some reason. I'm going to figure out the right spot inside E+ to close the files and build a dummy release tag and see how it goes.

[JasonGlazer]

To be honest I would not have expected that EnergyPlus not releasing a file was to blame. It is used in so many contexts, I am surprised it hadn't been found earlier.

[Myoldmopar]

Taskbar icon issue is now fixed. As far as I am concerned, this can merge in. But honestly, now that these little annoying paper cuts are cleaned up, I would be happy to take a couple hours reworking anything on the GUI that needs cleaned up. @JasonGlazer we could chat on Monday to discuss any final polishing you'd like done. Some things that come to mind:

• Moving the group file operations into buttons down by the group listing at the bottom.
• Adding a "title" for the group, which would either be the filename that was loaded, or "unnamed"
  • We could put some sort of "dirty" indicator for if the user opened a group file but then modified it
• More shortcut keys, and add a dialog to show shortcut keys dynamically

These are all small efforts, and now that the really annoying things are behind me, I'm open to dropping a few hours to wrap things like this up to maximize the usefulness.

[Myoldmopar]

Went ahead and added a couple tweaks this morning. I created a new dialog that displays the available keyboard shortcuts. I considered modifying the group menu and moving it down to the group section, but I felt like the UI had enough buttons, so I aborted. Once I get to test this out across platforms, I'm happy to call this done.

[Myoldmopar]

I noticed that the dialogs didn't have the same E+ icon, so fixed that up. It looks very nice now :star_struck:

[Myoldmopar]

Hey @JasonGlazer, do you have objections to merging this in? I'm looking over all the Python apps and am anxious to get this merged and properly releasing from the main branch so I can proceed cleanly toward the pip install energyplus world. If you are good with it, I'll bump the version one more time before we merge/release.

[JasonGlazer]

@Myoldmopar I haven't looked this over in a long time and never did a real review. I did some random UI testing only. If you are looking for a more careful review, I will work on it after I finish up the bug fix I'm working on.

[Myoldmopar]

Honestly, I think we should just merge it in. I am happy to give you more walkthrough and such, but I feel confident that we have reached a point that we need to get it "released" so that we can do these same fixups across our other tools. This is not perfect, I'm sure, but it's pretty darn good. Let's merge it.

[JasonGlazer]

Great step forward!