IDFVersionUpdater and Transition fail to update 6.0.0 file to 23.1 and stop at 9.2

NREL / EnergyPlus

EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.

https://energyplus.net

Other

1.05k stars 378 forks source link

IDFVersionUpdater and Transition fail to update 6.0.0 file to 23.1 and stop at 9.2 #10568

Open JasonGlazer opened 2 weeks ago

JasonGlazer commented 2 weeks ago

Issue overview

When trying to transition an old file, IDFVersionUpdater fails to go past 9.2.

https://unmethours.com/question/99322/conversion-of-idf-file-from-v6-to-current-v232-failed/

File in devsupport repo to reproduce the problem.

Details

Some additional details for this issue (if relevant):

Platform (Operating system, version)
Version of EnergyPlus (if using an intermediate build, include SHA)
Unmethours link or helpdesk ticket number

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

[ ] Defect file added (list location of defect file here)
[ ] Ticket added to EnergyPlus Defect Complexity (Github Project)
[ ] Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)

JasonGlazer commented 2 weeks ago

This is probably due to the following severe messages:

** Severe ** IP: IDF line~66602 Did not find "AirTerminal:SingleDuct:Uncontrolled" in list of Objects

The 8.9 to 9.0 transition issues warnings but by 9.3 to 9.4 they are fatal

JasonGlazer commented 2 weeks ago

Add code IDFVersionUpdate to stop trying to transition a file if a severe is found. Also, output errors are creating huge dialog box that is impossible to scroll through on this file.

JasonGlazer commented 2 weeks ago

This uncovered a few different problems, but what triggered it was the transition of the file from 9.1.0 to 9.2.0. That transition includes Table:TwoIndependentVariables to Table:Lookup but in the process of that transition it added a line of over a thousand character of ASCII zero.

When the 9.2.0 to 9.3.0 transition tries to parse the file with all the zero characters it crashes.

To fix:

Transition from 9.1.0 to 9.2.0
General routine in transition that reads to detect zeros (maybe not worth fixing)
IDFVersionUpdater to recognize a crash of Transition better and report that
IDFVersionUpdater dialog box that shows warnings and errors should be a scrolling list instead of a giant dialog that doesn't fix on a monitor
The Rules9-1-0-to-9-2-0.md doesn't discuss the Table input objects changing
Transition should see that an older version number is present and immediately end instead of trying to parse stuff that it can't transition.

JasonGlazer commented 2 weeks ago

As a workaround, when a file fails to transition after 9.2, it may be due to this bug. Open the 9.2 file in a text editor and look for a long string of ASCII zero characters and delete those characters. Continue transition process with the fixed file.