NREL / EnergyPlus

EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.
https://energyplus.net
Other
1.13k stars 389 forks source link

Supplemental Heat High Shutoff Temperature column is missing from table DX Heating Coils AHRI 2023 #10623

Open Nigusse opened 3 months ago

Nigusse commented 3 months ago

Issue overview

Table DX Heating Coils AHRI 2023 was created by splitting the data in table DX Heating Coils In PR #10588. Now, table DX Heating Coils has an additional column, Supplemental Heat High Shutoff Temperature, which does not exist in the new table DX Heating Coils AHRI 2023. These two tables should contain the same set of information. So, the Supplemental Heat High Shutoff Temperature column header should be added to the DX Heating Coils AHRI 2023 table.

Details

Some additional details for this issue (if relevant):

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Nigusse commented 3 months ago

See below the difference between these two tables:

image

Column Supplemental Heat High Shutoff Temperature must be a recent addition. @JasonGlazer, right?

JasonGlazer commented 3 months ago

Yes, it was added for the work related to Standard 229 to generate a "RPD" file.

Nigusse commented 3 months ago

@JasonGlazer Do you think you'll work on this, or should I include it in one of the PR that I am working on?

JasonGlazer commented 3 months ago

The Supplemental Heat High Shutoff Temperature should be done. If you come across a model that does not output that correctly, please let me know.

JasonGlazer commented 3 months ago

Or do you mean should it be int he AHRI 2023 table? I don't think it needs to be repeated, do you?

Nigusse commented 3 months ago

The last three columns in the current tables are repeated. These two tables should contain the same information, but I don't have a strong opinion either way. Let's leave it as is for now.