Remove FlowLock from plant components

[mjwitte]

Pull request overview

• Remove FlowLock from
  • ChillerElectricEIR.cc
• Add new worker function okToIssueWarning that checks WarmupFlag and component's loop side FlowLock.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• [ ] Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
• [ ] Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
• [ ] Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
• [ ] Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
• [ ] If any diffs are expected, author must demonstrate they are justified using plots and descriptions
• [ ] If changes fix a defect, the fix should be demonstrated in plots and descriptions
• [ ] If any defect files are updated to a more recent version, upload new versions here or on DevSupport
• [ ] If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
• [ ] If structural output changes, add to output rules file and add OutputChange label
• [ ] If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

• [ ] Perform a Code Review on GitHub
• [ ] If branch is behind develop, merge develop and build locally to check for side effects of the merge
• [ ] If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
• [ ] If feature, test running new feature, try creative ways to break it
• [ ] CI status: all green or justified
• [ ] Check that performance is not impacted (CI Linux results include performance check)
• [ ] Run Unit Test(s) locally
• [ ] Check any new function arguments for performance impacts
• [ ] Verify IDF naming conventions and styles, memos and notes and defaults
• [ ] If new idf included, locally check the err file and other outputs

[github-actions[bot]]

:warning: Regressions detected on macos-14 for commit f8928bfdbc87928b30f13b5c2b24a6253bc3f1f2

Regression Summary

- EIO: 22 - ERR: 3 - Table Big Diffs: 3 - Table String Diffs: 1 - ESO Big Diffs: 7 - MTR Small Diffs: 18 - ESO Small Diffs: 13 - Table Small Diffs: 6

• View Results
• Download Regressions

[github-actions[bot]]

:warning: Regressions detected on macos-14 for commit 9ed9d07e6ae71bef7a9f8a03b8491157977f54d2

Regression Summary

- EIO: 24 - ERR: 3 - Table Big Diffs: 4 - Table String Diffs: 1 - ESO Big Diffs: 7 - MTR Small Diffs: 20 - ESO Small Diffs: 15 - Table Small Diffs: 7

• View Results
• Download Regressions

[github-actions[bot]]

:warning: Regressions detected on macos-14 for commit 54a8d717b3e169900dc219fb6611e41a51244c9f

Regression Summary

- EIO: 2 - ESO Small Diffs: 2 - MTR Small Diffs: 2 - Table Small Diffs: 1 - Table Big Diffs: 1

• View Results
• Download Regressions

[github-actions[bot]]

:warning: Regressions detected on macos-14 for commit f3078995b850875f7a77282968ce9cb3d21552b9

Regression Summary

- EIO: 1 - ERR: 1 - ESO Big Diffs: 1 - Table Big Diffs: 1

• View Results
• Download Regressions

[nrel-bot-2c]

@mjwitte @myoldmopar it has been 28 days since this pull request was last updated.

[nrel-bot-2]

@mjwitte it has been 7 days since this pull request was last updated.