search

NREL / EnergyPlus

EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.
https://energyplus.net
Other
1.12k stars 389 forks source link

Disable system reports accounting when not needed #4939

Open mjwitte opened 9 years ago

mjwitte commented 9 years ago

Reference #4938 where @mbadams5 added some speed improvements to EnergyPlus::SystemReports::ReportSystemEnergyUse() and CalcSystemEnergyUse().

Not 100% certain, but my recollection is that the system reports code was added to support the Ventilation Load Reports https://www.energyplus.net/sites/default/files/docs/site_v8.3.0/InputOutputReference/01c-InputOutputReference/#outdoor-air-ventilation-outputs and possibly supports the Systems Level Reporting https://www.energyplus.net/sites/default/files/docs/site_v8.3.0/InputOutputReference/01c-InputOutputReference/#systems-level-reporting

My thinking is if none of the output variables in these groups have been requested, then the system reports code does not need to run, but it may be more complicated than that, and the logic to skip it may already be in place.

@mbadams5 Tested this: It appears like the system reports are run every time. I commented out all outputs in the IDF and it still has 7805ms and 4254ms for SystemReports::ReportSystemEnergyUse() and SystemReports::CalcSystemEnergyUse() respectively.

mjwitte commented 9 years ago

There is a flag AirLoopLoadsReportEnabled that should be disabling some parts of these routines when not needed.

Myoldmopar commented 9 years ago

@mjwitte I'm going to take this off of the 8.4 list.