NREL / EnergyPlus

EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.
https://energyplus.net
Other
1.1k stars 384 forks source link

Invalid time series SQL dat when using Site:GroundDomain:Slab with Finite Difference undisturbed ground temperatures in 8.4 #5314

Closed DavidGoldwasser closed 8 years ago

DavidGoldwasser commented 8 years ago

Model runs without any apparent errors, and tabular SQL data is fine. But time series data is missing. Below is text for the object, and screenshot from ResultsViewer

Site:GroundDomain:Slab,
  IngradeCoupledSlab,                     !- Name
  5,                                      !- Ground Domain Depth {m}
  1,                                      !- Aspect Ratio
  5,                                      !- Perimeter Offset {m}
  1.8,                                    !- Soil Thermal Conductivity {W/m-K}
  3200,                                   !- Soil Density {kg/m3}
  836,                                    !- Soil Specific Heat {J/kg-K}
  30,                                     !- Soil Moisture Content Volume Fraction {percent}
  50,                                     !- Soil Moisture Content Volume Fraction at Saturation {percent}
  Site:GroundTemperature:Undisturbed:FiniteDifference, !- Undisturbed Ground Temperature Model Type
  FDTemps,                                !- Undisturbed Ground Temperature Model Name
  1,                                      !- Evapotranspiration Ground Cover Parameter
  GroundCoupledOSCM,                      !- Slab Boundary Condition Model Name
  InGrade,                                !- Slab Location
  SLAB 8 HW CONCRETE,                     !- Slab Material Name
  No,                                     !- Horizontal Insulation
  ,                                       !- Horizontal Insulation Material Name
  ,                                       !- Horizontal Insulation Extents
  ,                                       !- Perimeter Insulation Width {m}
  Yes,                                    !- Vertical Insulation
  VERTICAL SLAB INSULATION,               !- Vertical Insulation Material Name
  1.5,                                    !- Vertical Insulation Depth {m}
  Timestep;                               !- Simulation Timestep

screen shot 2015-11-09 at 10 10 44 am

cc: @Myoldmopar

Myoldmopar commented 8 years ago

Sooooooo, I can't reproduce this.

On my build as of today, I ran the PipingSystem_Underground_TwoPipe_FD_GroundTemps.idf file with a debug build. One thing I did notice is that you definitely need a weather file specified, even if doing design day runs, since this model requires annual weather data to generate ground temps. But I digress.

The output in sqlite in the ReportData table looks like:

image

To verify, here is the eso output file (which becomes the csv in a typical workflow):

image

Same numbers. @DavidGoldwasser, I am curious if maybe something went wrong with the simulation because there was a missing weather file?

Anyway, I'll put a mental timer on this for about a day, and if no one can prove me wrong, I'm closing this.

DavidGoldwasser commented 8 years ago

@Myoldmopar I thought you were able to reproduce this? (See November 11th email).

Here is a link to the IDF https://www.dropbox.com/s/p63nsm0721r3moj/in.idf?dl=0

I ran it with USA_ID_Boise.Air.Terminal.726810_TMY3.epw

Myoldmopar commented 8 years ago

Yeah, I thought I had @DavidGoldwasser. I found the email, but I'm wondering if I hit the weather file issue and it made me think I had reproduced it. I'm re-running right now with your idf to see what's up. But as I showed above, I don't think it could really be anything related to the finite difference ground temp model, since it did report results properly above. I'll let you know.

Myoldmopar commented 8 years ago

Welp. I just ran your idf again, and it works. The SQLite output is fully populated in the ReportData table:

image

The eso output matches:

image

We can chat about it later, but for now I'm moving on to other bugs.

mitchute commented 8 years ago

@Myoldmopar I will add the error handling so the weather file issue is handled.

DavidGoldwasser commented 8 years ago

@Myoldmopar ok, I'm fine with it closing as long as it runs in develop. I was using 8.4 on Linux, and windows. You did try to look at time series sql data vs just tabular?

Myoldmopar commented 8 years ago

So I don't deal much with the sql data, but as far as I could tell, that was the time series data, not the data that goes out to the tabular results. Of course it is in an sql table within the sql file, but that's a different story...

I'll try to remember to let you know when we create a Windows test package of 8.4.0+BugFix so that we can re-test it.

I'll close this for now.......