NREL / EnergyPlus

EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.
https://energyplus.net
Other
1.1k stars 384 forks source link

Documentation Issues - 2017 #5997

Closed mjwitte closed 5 years ago

mjwitte commented 7 years ago

The last sentence should read "The bicubic curve should be valid for the range of water temperatures and part-load ratios anticipated for the simulation (otherwise the program issues warning messages)."

Addressed in Pull Request 160251551_Issue#5997

mjwitte commented 7 years ago

Addressed in Pull Request 160251551_Issue#5997

mjwitte commented 7 years ago

Addressed in Pull Request 160251551_Issue#5997

mjwitte commented 7 years ago

This is out of date, and should read: If the Sky Diffuse Modeling Algorithm (ShadowCalculation object) is set to SimpleSkyDiffuseModeling, then Rhorizon and Rdome are calculated once for each surface since they are independent of sun position. If the Sky Diffuse Modeling Algorithm is set to DetailedSkyDiffuseModeling, then Rhorizon and Rdome are calculated every timestep for each surface."

Addressed in Pull Request 160251551_Issue#5997

mjwitte commented 7 years ago
JasonGlazer commented 7 years ago

Addressed in Pull Request 160251551_Issue#5997

mjwitte commented 7 years ago

Addressed in Pull Request 160251551_Issue#5997

aaron-boranian commented 7 years ago

Addressed in Pull Request 160251551_Issue#5997

mjwitte commented 7 years ago

Addressed in Pull Request 160251551_Issue#5997

mjwitte commented 7 years ago

Posted new issue #6947 for this.

mjwitte commented 7 years ago

Addressed in Pull Request 160251551_Issue#5997

aaron-boranian commented 7 years ago

Addressed in Pull Request 160251551_Issue#5997

mjwitte commented 7 years ago

The underscore appears everywhere in the documentation where "\begin{lstlisting} ... \end{lstlisting}" is used as designed. It is OK as is.

aaron-boranian commented 7 years ago

Addressed in Pull Request 160251551_Issue#5997

aaron-boranian commented 7 years ago

Addressed in Pull Request 160251551_Issue#5997

aaron-boranian commented 7 years ago

screen shot 2017-07-06 at 9 25 03 am

screen shot 2017-07-06 at 9 23 46 am

Addressed in Pull Request 160251551_Issue#5997

MatthewSteen commented 7 years ago

The heating or cooling output of the unit ventilator fan coil unit is controlled by varying the air flow rate, the water flow rate, or both. Air flow rate can be controlled by cycling the fan on/off or with a variable speed fan drive. (source code)


https://github.com/NREL/EnergyPlus/issues/5997#ref-commit-7724958

Included Matthew's fix here 160251551_Issue#5997.

aaron-boranian commented 7 years ago

This is not an exhaustive list. Addressed in Pull Request 160251551_Issue#5997

aaron-boranian commented 7 years ago

Posted new issue here.

JasonGlazer commented 7 years ago

@aaron-boranian the Engineering Reference includes a section on the Zone Component Loads Summary report already here. What further clarification is needed in that section?

aaron-boranian commented 7 years ago

@JasonGlazer that section essentially just lists all the load components, but doesn't define them. For example, new users or energy modelers may not be familiar with the difference between infiltration, ventilation, and zone mixing load components. It would be nice to include equations that explicitly show how each load component is calculated.

JasonGlazer commented 7 years ago
JasonGlazer commented 7 years ago

Addressed in Pull Request 160251551_Issue#5997

mjwitte commented 6 years ago

"1.53.1.2.17 Water Use Equipment Heating Energy [J] The heating energy accumulated by the heating rate above, in units of Joules (J). This output is also added to a meter with End Use Key = WaterSystems, Group Key = Plant. If both of the node names specified in the WaterUse:Equipment object are blank, then this output is reported with Resource Type = DistrictHeating. If either of the node names are entered, then this output is reported with Resource Type = EnergyTransfer. The sub-categories may be entered as any type (e.g., Laundry, Dish Washing, etc. defined in WaterUse:Equipment object input for End-Use Subcategory) with General being the default sub-category (ref. Output Meter)"

Addressed in Pull Request 160251551_Issue#5997

JasonGlazer commented 6 years ago

Addressed in Pull Request 160251551_Issue#5997

mjwitte commented 6 years ago

Addressed in Pull Request 160251551_Issue#5997

MatthewSteen commented 6 years ago

Step 4. Put the nonrecurring, nonrecurring, and utility costs into a monthly array for the entire length of the study period.

should be:

Step 4. Put the nonrecurring, recurring, and utility costs into a monthly array for the entire length of the study period.


https://github.com/NREL/EnergyPlus/issues/5997#ref-commit-7724958 Included Matthew's fix here 160251551_Issue#5997.

JasonGlazer commented 6 years ago

Addressed in Pull Request 160251551_Issue#5997

JasonGlazer commented 6 years ago

Addressed in Pull Request 160251551_Issue#5997

MatthewSteen commented 6 years ago

Pump:VariableSpeed IO documentation

This numeric field contains the pump's ~rated~ design head pressure in Pascals. The default is 179352 Pa, or 60 ftH20, and is for a fairly large building.

This numeric field contains the pump ~'s~ motor's efficiency in decimal form (0 = 0\%, 1 = 100\%).

Pump:ConstantSpeed IO documentation

This numeric field contains the pump’s ~rated~ design power consumption in Watts. If the user is performing a pressure simulation on the loop in which this pump is found, this value would only be used to estimate pump efficiency. During reported calculations, the pump would use the loop pressure drop and current flow conditions along with efficiency to calculate pump power dynamically. This field can be autosized. When set to autosize the type of scaling factor is chosen in the input field Design Power Sizing Method.

This numeric field contains the pump ~'s~ motor's efficiency in decimal form (0 = 0\%, 1 = 100\%).


https://github.com/NREL/EnergyPlus/issues/5997#ref-commit-7724958 Included Matthew's fix here 160251551_Issue#5997.

Nigusse commented 6 years ago

@mjwitte @Myoldmopar All but two issues listed in this documentation are addressed. Two of the issues should be addressed separately (each) and posted two new issues here and here.

Nigusse commented 6 years ago

@JasonGlazer I think the "Zone Component Load Summary" issue listed above warrants a separate issue by itself. What do you think?

JasonGlazer commented 6 years ago

@Nigusse Sure, although I still believe that the section in the engineering reference that describes the Zone Component Loads Summary is sufficient for understanding how it works.

Nigusse commented 6 years ago

@JasonGlazer @mjwitte @Myoldmopar I will post a separate issue for "Zone Component Load Summary" calculation definitions or equations request as a place holder for next release consideration.

Nigusse commented 6 years ago

@mjwitte @Myoldmopar The only issue remaining now is "- [ ] In the Auxiliary Programs document, the example def files for the Weather Converter show backslashes and underscores in many places. These should not be in the final pdf."

The underscore appears everywhere in the documentation where "\begin{lstlisting} ... \end{lstlisting}" listing template is used. I think this is a a standard template in LaTex mainly used to add code snippet to a documentation as described here. I don't know enough if we can customize it to remove the underscore.

mjwitte commented 6 years ago

@Nigusse I'm confused. I don't see any problems in the current Auxiliary Programs doc def file listings. Even going back several releases. I don't know what prompted me to post this comment.

Nigusse commented 6 years ago

@mjwitte Ok. Thanks. I will mark it as designed.

Myoldmopar commented 5 years ago

Closed by #6946