NREL / EnergyPlus

EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.
https://energyplus.net
Other
1.15k stars 392 forks source link

Outdoor air node wet-bulb EMS override only work with with OutdoorAir:Node not OutdoorAir:NodeList and other problems #6506

Closed mjwitte closed 6 years ago

mjwitte commented 6 years ago

Issue overview

  1. In OutAirNodeManager::GetOutAirNodeInputs the input processing for OutdoorAir:Node sets AnyLocalEnvironmentsInModel = true if there is more than one alpha field. This is wrong - it will cause a performance hit elsewhere in the code if local environments are not really being used. This should test if AnyLocalEnvironmentsInModel == true in deciding whether to set the IsLocalNode flag.

  2. In OutAirNodeManager::InitOutDoorAirNodes the logic for setting humrat needs to be much more general. a. It should not rely on IsLocalNode because EMS or schedules could be used to override OA node data even without using the local environments model. b. It needs a flag that gets set if any of the overrides for EMS dry bulb, EMS wet bulb, drybulb schedule, or wet bulb schedule are active and then recalculate humrat. c. But what if only dry bulb is overridden - then humrat should use the OA condition and wetbulb should be recalculated? d. And shouldn't the OA condition be height-based if applicable? e. Other cases I haven't thought of here?

  3. There is a similar block of code in CheckAndAddAirNodeNumber. These should be consolidated into a single function that sets a single node.

Workaround

Use OutdoorAir:Node with the last field non-blank for any OA node that will have an EMS override for wetbulb temperature.

OutdoorAir:Node,
    Node 12,                 !- Name
    ,                        !- Height Above Ground {m}
    ,                        !- Drybulb Temperature Schedule Name
    ,                        !- Wetbulb Schedule Name
    ,                        !- Wind Speed Schedule Name
    ,                        !- Wind Direction Schedule Name
    ,                        !- Wind Pressure Coefficient Curve Name
    ,                        !- Symmetric Wind Pressure Coefficient Curve
    Absolute;                !- Wind Angle Type

Details

Some additional details for this issue (if relevant):

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Myoldmopar commented 6 years ago

Closed via #6841