Old fan objects - time to tag obsolete?

mjwitte commented 5 years ago

Issue overview

Fan:SystemModel was developed to replace Fan:OnOff, Fan:ConstantVolume, Fan:VariableVolume, and FanPerformance:NightVentilation. It was added in v8.7 (March 2017).

Is it time to mark the old fan objects as obsolete and plan to remove them in v9.1 or 9.2?

While testing the new fan energy index output, noticed that FanPerformance:NightVentilation is not used in any example files. This happened back in v8.7 when Fan:SystemModel was introduced. At that time, 5ZoneNightVent3 was changed to use Fan:SystemModel which has a fields for Night Ventilation Mode Pressure Rise and Flow Fraction. I thought about adding a new example file 5ZoneNightVent3b that uses the old fan objects, but why bother when this object is obsolete.

Details

Some additional details for this issue (if relevant):

Version of EnergyPlus v9.0

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

[ ] Defect file added (list location of defect file here)
[ ] Ticket added to Pivotal for defect (development team task)
[ ] Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)

jasondegraw commented 5 years ago

@mjwitte I'd personally prefer that we wait to make that move until after there is full AirflowNetwork support for the new fan object. (see #6642)

mjwitte commented 5 years ago

@jasondegraw Didn't realize that was missing. So, that needs to come first. Is that a big lift?

jasondegraw commented 5 years ago

@mjwitte I think it'd be a medium-sized lift, @lgu1234 do you agree?

lgu1234 commented 5 years ago

@jasondegraw Yes. I agree.

shorowit commented 2 years ago

Fan:SystemModel is now supported in AFN; is now the time to deprecate the old objects?

NREL / EnergyPlus