CLI fails to run ReadvarsESO successfully when rvi or mvi file is present with --output-prefix option

mjwitte commented 5 years ago

Issue overview

Using EP-Launch 3, SI option, the CLI fails to produce csv outputs if an rvi or mvi file exists. The resulting error is:

ReadVarsESO program starting.
Requested ESO file=eplusout.eso
does not exist.  ReadVarsESO program terminated.

EP-Launch 3 is using the --output-prefix option (and others) which may be part of the issue here.

Details

Some additional details for this issue (if relevant):

Platform Windows 10
Version of EnergyPlus v9.2.0-RC3

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

[x] Defect file added (list location of defect file here) - run 5ZoneAirCooled with EP-Launch 3 and it will produce meter.csv, but not the main csv
[ ] Ticket added to Pivotal for defect (development team task)
[ ] Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)

mjwitte commented 5 years ago

More information - so, actually, this isn't necessarily broken. The problem is if you use the output prefix option, eplusout.eso doesn't exist. But all of the example rvi/mvi files have the filename "eplusout.eso" at the top . . . . so it's not there.

mjwitte commented 5 years ago

A possible fix is to add a path argument to readvarseso to override the filenames in the rvi/mvi.

Another possible fix is to assume these filenames will always be eplusout.... and have cli move the eso and mtr outputs to eplusout.eso/mtr before running readvars, then after to move eplusout.csv to the appropriate path.

Or leave things as-is, but add content to the readvars error message instructing the user to check the filenames in the rvi/mvi.

NREL / EnergyPlus