Potential bug in CalcDesignSpecificationOutdoorAir related to max OA flow rate

mitchute commented 3 years ago

Issue overview

Issue discovered while refactoring for state. See here: https://github.com/NREL/EnergyPlus/blob/f754bc5c2c5d415789c9b01297c575772833b862/src/EnergyPlus/DataZoneEquipment.cc#L1408-L1414
At the very least, this is a duplicated code path that should be eliminated. However, it should be traced back up through the code just to make sure this is not a bug.

Details

Some additional details for this issue (if relevant):

Version of EnergyPlus (V9.4.0 f754bc5c2c5d415789c9b01297c575772833b862)
Unmethours link or helpdesk ticket number - N/A

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

[ ] Defect file added (list location of defect file here)
[ ] Ticket added to Pivotal for defect (development team task)
[ ] Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)

mitchute commented 3 years ago

FYI @mjwitte. Posting here so I don't forget about it.

jmarrec commented 3 years ago

Same exact code in fortran: https://github.com/NREL/EnergyPlusArchive/blob/92ffc69755ab1ed2315a7a49a9b04fb000aecb25/SourceCode/DataZoneEquipment.f90#L1502-L1508

This is the commit that added it 9 years ago: https://github.com/NREL/EnergyPlusArchive/commit/e554cb750d688090042757999694495e161aec40. Never been touched since.

rraustad commented 3 years ago

There was a discussion back then of whether or not this calculation should use the actual occupancy schedule value or the maximum zone occupancy. I believe MaxOAVolFlowFlag was meant to trigger that decision.

NREL / EnergyPlus