NREL / EnergyPlus

EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.
https://energyplus.net
Other
1.06k stars 379 forks source link

Change ObjexxFLC "bit_" functions with C++ operators in psychrometric and fluid property caching #8815

Closed JasonGlazer closed 3 years ago

JasonGlazer commented 3 years ago

Issue overview

The caching code in psychrometrics and fluid properties uses ObjexxFLC functions:

which should be replaced with native ">>" and "&" and "|" and "^" operators to increase performance.

Details

Some additional details for this issue (if relevant):

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

mitchute commented 3 years ago

@JasonGlazer I've got a branch locally that has started addressing this. I can take care of it unless you already have the work done.

JasonGlazer commented 3 years ago

@mitchute that is terrific. I started working on it in one place and was using reinterpret_cast but it seemed to be getting hung up on types which did not seem to make sense to me. I'm sure you understand this better than me.

amirroth commented 3 years ago

@mitchute can you get that merged? I would like to try something that builds on top of it. Thx.

mitchute commented 3 years ago

This was addressed by #8818