Closed matthew-larson closed 2 years ago
There may be a reason for some of these to recalc with updated air temperatures during the system timesteps, just guessing.
For sure the blocks of code for this in CalcHeatBalanceInsideSurf2
and CalcHeatBalanceInsideSurf2CTFOnly
can be pulled out into a common function.
That was my thought too so I'll double check for necessary recalcs.
This was put in as part of the EnergyPlus 0.01X project.
Issue overview
The same surface reference air temperature calculation was found to be done in multiple locations (WindowManager.cc, WindowComplexManager.cc, WindowEquivalentLayer.cc, and ZoneTempPredictorCorrector.cc) after the initial calculation in HeatBalanceSurfaceManager.cc. The results from HeatBalanceSurfaceManager.cc (
state.dataHeatBalSurfMgr->RefAirTemp(SurfNum)
andstate.dataHeatBal->SurfTempEffBulkAir(SurfNum)
) should be able to be referenced and used in the other locations without having to redo the calculation over again.Details
Some additional details for this issue (if relevant):
Checklist
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.