Miscellaneous Daylighting Code Refactoring

[mjwitte]

Issue overview

While working on changes to daylighting for Spaces, there were several comments suggesting further refactoring. These comment links aren't the greatest (because they don't show the line of code being commented on), but following into the specific commits will show the line of code at the time. These comments were posted during 9.6.0 development (roughly August-Sept 2020), so it's possible some of this code has already changed due to other refactoring sweeps.

• [ ] https://github.com/NREL/EnergyPlus/pull/9102#pullrequestreview-765888211
• [ ] https://github.com/NREL/EnergyPlus/pull/9102#pullrequestreview-765891543
• [ ] https://github.com/NREL/EnergyPlus/pull/9102#pullrequestreview-765893043
• [ ] https://github.com/NREL/EnergyPlus/pull/9102#commitcomment-57189877
• [ ] https://github.com/NREL/EnergyPlus/pull/9002#commitcomment-55502612
• [ ] https://github.com/NREL/EnergyPlus/pull/9002#commitcomment-55502612
• [ ] https://github.com/NREL/EnergyPlus/pull/9002#commitcomment-55551783
• [ ] https://github.com/NREL/EnergyPlus/pull/9002#discussion_r711424850
• [ ] https://github.com/NREL/EnergyPlus/pull/9067#commitcomment-56545086
• [ ] https://github.com/NREL/EnergyPlus/pull/9067#commitcomment-56545213
• [ ] See if call to DaylightingManager::initDaylighting in HeatBalanceSurfaceManager::InitSurfaceHeatBalance can be skipped if there's no daylighting in the model - or maybe skip some sections in that function.

Details

Some additional details for this issue (if relevant):

• Platform (Operating system, version)
• Version of EnergyPlus (if using an intermediate build, include SHA)
• Unmethours link or helpdesk ticket number

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• [ ] Defect file added (list location of defect file here)
• [ ] Ticket added to Pivotal for defect (development team task)
• [ ] Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)

[JasonGlazer]

While refactoring DaylightingManager.hh please also think about eliminating use of so many old short Fortran variable names such as DILLSW (and dozens of other 2 to 6 character variable names in all caps).