SurfaceProperty:LocalEnvironment and SurfaceProperty:SurroundingSurfaces: IDD adjustments

jmarrec commented 2 years ago

Issue overview

The example file actually references a FenestrationSurface:Detailed object, which is NOT part of the SurfaceNames object list. https://github.com/NREL/EnergyPlus/blob/923772d985c14e803c7ae0e5348a2d595fe5739d/testfiles/SurfacePropTest_SurfLWR.idf#L2301-L2306

SurfaceProperty:LocalEnvironment
   A2, \field Exterior Surface Name
       \type object-list
-      \object-list SurfaceNames
+    # Either one of these two probably
+     \object-list SurfAndSubSurfNames
+     \object-list AllHeatTranSurfNames
       \note Enter the name of an exterior surface object

SurfaceProperty:SurroundingSurfaces: the Sky view factor and Ground view factors are autocalculated, so they should be marked as such. (At the very least, they should NOT have a default, because blank means it's autocalculated) https://bigladdersoftware.com/epx/docs/9-6/input-output-reference/group-advanced-surface-concepts.html#surfacePropertysurroundingSurfaces

SurfaceProperty:SurroundingSurfaces,
   N1, \field Sky View Factor
       \minimum 0.0
       \maximum 1.0
-      \default 0.5
+     \autocalculatable 
+     \default autocalculate
       \note optional

   N2, \field Ground View Factor
       \minimum 0.0
       \maximum 1.0
-      \default 0.5
+     \autocalculatable 
+     \default autocalculate
       \note optional

Details

Some additional details for this issue (if relevant):

Platform (Operating system, version): all
Version of EnergyPlus (if using an intermediate build, include SHA): develop, 923772d985c14e803c7ae0e5348a2d595fe5739d

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

[ ] Defect file added (list location of defect file here)
[ ] Ticket added to Pivotal for defect (development team task)
[ ] Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)

shorowit commented 2 years ago

On the first item, this question suggests that the SurfaceProperty:LocalEnvironment object ~does not apply to~ has no simulation output effect for a FenestrationSurface:Detailed object. Also related to the last point in @mjwitte's comment here.

mjwitte commented 2 years ago

SurfaceProperty:LocalEnvironment is supposed to apply to fenestration objects, and as noted in this issue, it's an IDD error that makes it appear that this is not allowed. The example file does apply this to a window(s). I guess I haven't confirmed that it actually works for the window. As with most things, and especially with software, trust, but verify.

SurfaceProperty:LocalEnvironment does work for fenestration surfaces. See example files SurfacePropTest_SurfLWR and SolarShadingTest_ExternalFraction.
However, External Shading Fraction Schedule Name only works is ShadowCalculation "Shading Calculation Method" = Scheduled.
And it only works for RunPeriod simulations (not for SizingPeriod:DesignDays, did not test SizingPeriod:WeatherFileDays).

So, not only does the IDD need updates, and notes, there should be a warning if External Shading Fraction Schedule Name is used when the Shadow Calculation Method is not "Schedule". OR better yet, figure out how to overlay this on the other shadow calculation methods, so it can be used to adjust certain surfaces which the main method handles all of the others.

mjwitte commented 2 years ago

Also note that there is no check on the scheduled sunlit fraction. The value can be anything, even if the surface would be in shade due to sun position. Here are some test files 9275-v9.5.zip Sorry they're v9.5 'cause that runs with ep-launch with external schedule files without updating the file paths. .

mjwitte commented 2 years ago

See also https://github.com/NREL/EnergyPlus/issues/6935 - that field name change should happen along with these idd changes.

NREL / EnergyPlus