WindowProperty:FrameAndDivider IDD missing either required-field or default value - Githubissues

NREL / EnergyPlus

EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.

https://energyplus.net

Other

1.11k stars 388 forks source link

WindowProperty:FrameAndDivider IDD missing either required-field or default value #9344

Open jmarrec opened 2 years ago

jmarrec commented 2 years ago

Issue overview

Frame Conductance should be either \required-field or have a default. Currently it's read as 0.0 if not supplied

WindowProperty:FrameAndDivider,
   [...]
    N4 , \field Frame Conductance
         \units W/m2-K
         \type real
         \minimum 0.0
         \note Effective conductance of frame
         \note Excludes air films
         \note Obtained from WINDOW 5 or other 2-D calculation

https://github.com/NREL/EnergyPlus/blob/d073dda04b3b1198e263ef36d6a25d1c17e7b4c8/src/EnergyPlus/HeatBalanceManager.cc#L6647

(best addressed in conjunction with other IDD adjustements, search for https://github.com/NREL/EnergyPlus/issues?q=is%3Aissue+is%3Aopen+IDD+label%3AIDDChange)

Details

Some additional details for this issue (if relevant):

Platform (Operating system, version): all
Version of EnergyPlus (if using an intermediate build, include SHA): V22-1-0-IOFreeze at d073dda04b

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

[ ] Defect file added (list location of defect file here)
[ ] Ticket added to Pivotal for defect (development team task)
[ ] Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)

jmarrec commented 2 years ago

Additionally, these two should be integers not real

  N10, \field Number of Horizontal Dividers
-      \type real
+      \type integer
       \minimum 0
       \default 0
       \note "Horizontal" means parallel to local window X-axis
  N11, \field Number of Vertical Dividers
-      \type real
+      \type integer
       \minimum 0
       \default 0
       \note "Vertical" means parallel to local window Y-axis

https://github.com/NREL/EnergyPlus/blob/d073dda04b3b1198e263ef36d6a25d1c17e7b4c8/src/EnergyPlus/DataSurfaces.hh#L956-L957