GroundHeatExchanger:HorizontalTrench and other objects have redundant IDD fields that are on the Undisturbed Ground Temperature Model - Githubissues

NREL / EnergyPlus

EnergyPlus™ is a whole building energy simulation program that engineers, architects, and researchers use to model both energy consumption and water use in buildings.

https://energyplus.net

Other

1.11k stars 388 forks source link

GroundHeatExchanger:HorizontalTrench and other objects have redundant IDD fields that are on the Undisturbed Ground Temperature Model #9788

Open jmarrec opened 1 year ago

jmarrec commented 1 year ago

Issue overview

The same applies to these objects:

Site:GroundDomain:Slab
Site:GroundDomain:Basement
PipingSystem:Underground:Domain
GroundHeatExchanger:HorizontalTrench
GroundHeatExchanger:Slink

All three Site:GroundTemperature:Undisturbed:XXX (KusudaAchenbach, Xing, FiniteDifference) have these three required numeric fields: {'Soil Density', 'Soil Specific Heat', 'Soil Thermal Conductivity'}
The aforementionned objects all have a required Undisturbed Ground Temperature Model Name
The aforementionned objects all have these three numeric fields anyways, which is redundant

Details

Some additional details for this issue (if relevant):

Platform (Operating system, version): all
Version of EnergyPlus (if using an intermediate build, include SHA): 22.2.0

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

[ ] Defect file added (list location of defect file here)
[ ] Ticket added to Pivotal for defect (development team task)
[ ] Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)

shorowit commented 1 year ago

Related to https://github.com/NREL/EnergyPlus/issues/9701