search

NREL / EnergyPlusRegressionTool

Tools for running regressions on EnergyPlus outputs
https://energyplus.net
Other
9 stars 11 forks source link

No csv output on Windows for files with rvi or mvi #56

Open mjwitte opened 4 years ago

mjwitte commented 4 years ago

On Windows, files with an rvi don't produce a csv output, and so any eso diffs go unreported. e.g. 5ZoneAirCooled.

mjwitte commented 4 years ago

Also, related but maybe should be a different issue, the csv diff files display with blank rows on Windows (eplusout.csv.diffsummary.csv, eplusout.csv.absdiff.csv, and eplusout.csv.percdiff.csv). The line endings are CRCRLF (0D 0D 0A).

mjwitte commented 4 years ago

Found a temporary fix, in energyplus.py this line works (with some extra output to the command window which is fine for now)

            csv_run = subprocess.Popen(readvars + ' in.rvi')

this line does not, no csv and no readvars.audit file

            csv_run = subprocess.Popen(readvars + ' in.rvi', shell=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE)

I wonder if windows want the first argument here to be wrapped in double quotes?

mjwitte commented 4 years ago

Also, we want the 'unlimited' argument after the filename which must be the second argument, either an rvi/mvi filename or a pair of quotes as a placeholder. Seems we should just always create a stub rvi/mvi file if one isn't present and the always add the unlimited argument: readvars + 'in.rvi unlimited' (or mvi).