softwareengineerprogrammer
commented
3 months ago @malcolm-dsider check test is failing due pre-commit hooks not being applied (i.e. formatting and basic code checks).
Output from test log:
ruff.....................................................................Failed
- hook id: ruff
- exit code: 1
- files were modified by this hook
Fixed 9 errors:
- src/hip_ra_x/hip_ra_x.py:
5 × Q000 (bad-quotes-inline-string)
3 × F541 (f-string-missing-placeholders)
1 × I001 (unsorted-imports)
Found 9 errors (9 fixed, 0 remaining).
black....................................................................Failed
- hook id: black
- files were modified by this hook
reformatted src/hip_ra_x/hip_ra_x.py
All done! ✨ 🍰 ✨
1 file reformatted, 34 files left unchanged.
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
debug statements (python)................................................Passed
pre-commit hook(s) made changes.
If you are seeing this message in CI, reproduce locally with: `pre-commit run --all-files`.
To run `pre-commit` as part of git workflow, use `pre-commit install`.
All changes made by hooks:
diff --git a/src/hip_ra_x/hip_ra_x.py b/src/hip_ra_x/hip_ra_x.py
index f9bd144..16b26b7 100644
--- a/src/hip_ra_x/hip_ra_x.py
+++ b/src/hip_ra_x/hip_ra_x.py
@@ -8,7 +8,6 @@
from pathlib import Path
import pint
-
from rich.console import Console
from rich.table import Table
@@ -944,13 +943,13 @@ def PrintOutputsHTML(self, inputs, outputs, output_filename: str = 'HIP.html'):
self.logger.info(f'Init {__class__.__name__!s}: {__name__}')
try:
- inputs_table = Table(title="***SUMMARY OF INPUTS***")
+ inputs_table = Table(title='***SUMMARY OF INPUTS***')
inputs_table.add_column('Parameter Name', no_wrap=True)
- inputs_table.add_column('Value', no_wrap=True, justify="center")
+ inputs_table.add_column('Value', no_wrap=True, justify='center')
inputs_table.add_column('Units', no_wrap=True)
- outputs_table = Table(title="***SUMMARY OF RESULTS***")
+ outputs_table = Table(title='***SUMMARY OF RESULTS***')
outputs_table.add_column('Result Name', no_wrap=True)
- outputs_table.add_column('Value', no_wrap=True, justify="center")
+ outputs_table.add_column('Value', no_wrap=True, justify='center')
outputs_table.add_column('Units', no_wrap=True)
for key, value in inputs['SUMMARY OF INPUTS'].items():
@@ -983,10 +982,10 @@ def PrintOutputsHTML(self, inputs, outputs, output_filename: str = 'HIP.html'):
unit = unit.replace('deg', '\u00b0')
outputs_table.add_row(name, val, unit)
- console = Console(style="bold white on blue", force_terminal=True, record=True)
- console.print(f' *********************')
- console.print(f' ***HIP CASE REPORT***')
- console.print(f' *********************')
+ console = Console(style='bold white on blue', force_terminal=True, record=True)
+ console.print(' *********************')
+ console.print(' ***HIP CASE REPORT***')
+ console.print(' *********************')
console.print(' ')
console.print(inputs_table)
console.print(' ')
@@ -1020,7 +1019,6 @@ def PrintOutputsHTML(self, inputs, outputs, output_filename: str = 'HIP.html'):
self.logger.critical(msg)
raise
-
def __str__(self):
return 'HIP_RA_X'
check: exit 1 (20.09 seconds) /home/runner/work/GEOPHIRES-X/GEOPHIRES-X> pre-commit run --all-files --show-diff-on-failure pid=1919
check: FAIL code 1 (31.45=setup[4.35]+cmd[0.38,6.64,20.09] seconds)
evaluation failed :( (31.54 seconds)
Error: Process completed with exit code 1.
pre-commit setup is described in Step 3 of Local Setup instructions: https://github.com/NREL/GEOPHIRES-X/blob/main/CONTRIBUTING.rst#local-setup. To resolve this, set up pre-commit as described in Step 3, then:
- Run
pre-commit run --all-files --show-diff-on-failure git add .orgit add <file>for individual files if you have other in-flight work you don't want to include in the PR right now.git commit -m "Fix check errors (pre-commit)"- pre-commit will either pass or fail. If it fails and modifies files, go back to step 2 and continue. If it fails without modifying files (giving a message along the lines that it can't fix or only unsafe fixes are available), you will have to look at the individual failures/error codes and discern the resolution. Feel free to post those on this thread and I can try to take a look.
malcolm-dsider
Use Rich text library to allow for optional HTML output of the results.