search

NREL / GEOPHIRES-X

MIT License
28 stars 24 forks source link

Incorrect Parameter Settings in Example 3 #168

Closed huhanyu closed 5 months ago

huhanyu commented 6 months ago

In Example 3, there seems to be an issue with the parameter settings related to cracks，including Fracture Shape, Fracture Area, Number of Fractures, and Fracture Separation. As stated in the user manual, these parameters are not necessary and do not affect the simulation results.

Since the "Number of Fractures" parameter does not affect the simulation results, should the "Reservoir Volume Option" only be set to 4 instead of defaulting to 3 as stated in the user manual? I am not sure if there are similar issues in Example 4, please confirm. I have repeatedly adjusted their values and confirmed that they have no impact on the simulation.

It would be helpful if this could be clarified in the documentation or if the unnecessary parameters could be removed from the example to avoid confusion.

d1a3a8a04437d2d27b4e1e8b664a5e4

1e64b8fa567ffd08da65d032e368bb5 8aa2da05faffb1d8308062256845e73

09c25ee4080d62f3f8e428522e220e4

softwareengineerprogrammer commented 6 months ago

@huhanyu Thanks for filing. I have assigned myself to look when time permits. In the meantime, if you are able to file a PR with a suggested fix, that will help us evaluate more efficiently and may expedite resolution.

huhanyu commented 6 months ago

I've submitted a pr request to tweak example3 to make it conform to the user manual @softwareengineerprogrammer

softwareengineerprogrammer commented 6 months ago

@huhanyu We discussed this in our sync and the outcome was we decided this is not a bug, marking as wontfix for now. (I will write up a more detailed explanation when time permits, but just wanted to give you the relevant update in the meantime.)

Thanks for submitting this issue - it is valuable feedback regardless of the outcome. Please don't hesitate to submit further issues and questions, we really appreciate them!