search

NREL / GEOPHIRES-X

MIT License
28 stars 24 forks source link

Parameter generation missing Reservoir classes #174

Closed softwareengineerprogrammer closed 4 months ago

softwareengineerprogrammer commented 6 months ago

https://github.com/NREL/GEOPHIRES-X/blob/d663ad4f83fe6789e72efa5e2f8af675e1af5770/src/geophires_x_schema_generator/__init__.py#L52-L53

Appears to be missing LHSReservoir, MPFReservoir, SFReservoir - these should probably be included unless there is some special reason why they are redundant/conflicting with the CylindricalReservoir/SUTRAReservoir