search

NREL / GEOPHIRES-X

MIT License
28 stars 24 forks source link

Fix MC HIP-RA test #178

Closed softwareengineerprogrammer closed 6 months ago

softwareengineerprogrammer commented 6 months ago

Addresses https://github.com/NREL/GEOPHIRES-X/issues/151

Note: test was broken due to relative output path issue; this issue is still present if output file is passed in settings file (rather than MonteCarloRequest) - added FIXME in https://github.com/NREL/GEOPHIRES-X/pull/178/files#diff-d6aa9193390bfa4a8a702d91c930ef178551f54dfbbd5bbaf785c467d7e28800R462-R463, will create separate tracking issue for this since MC itself is 'fixed' by this PR in terms of having a passing test for reference

softwareengineerprogrammer commented 6 months ago

Thanks for approving @malcolm-dsider!

Merged and created follow-up issue per description: https://github.com/NREL/GEOPHIRES-X/issues/179?title=MC+Settings+Output+File+path+issues