search

NREL / GEOPHIRES-X

MIT License
26 stars 21 forks source link

Fix docs rendering issue #187

Closed softwareengineerprogrammer closed 2 months ago

softwareengineerprogrammer commented 2 months ago

Newlines in updated well drilling cost correlation were causing rendering issue in docs, now fixed:

Screenshot 2024-04-22 at 12 10 39
malcolm-dsider commented 2 months ago

Thanks for tracking that down, but when I look at:

https://nrel.github.io/GEOPHIRES-X/parameters.html#economics

I don’t see the fix… maybe there is an update I have to wait for in order to see it in Production?

From: Jonathan Pezzino @.> Sent: Monday, April 22, 2024 1:14 PM To: NREL/GEOPHIRES-X @.> Cc: Malcolm Ross @.>; Review requested @.> Subject: [NREL/GEOPHIRES-X] Fix docs rendering issue (PR #187)

Newlines in updated well drilling cost correlation were causing rendering issue in docs, now fixed:

Screenshot.2024-04-22.at.12.10.39.png (view on web) https://github.com/NREL/GEOPHIRES-X/assets/4056124/84e5e131-cb2b-4962-a041-31b2847ac4f1

You can view, comment on, or merge this pull request online at:

https://github.com/NREL/GEOPHIRES-X/pull/187

Commit Summary

File Changes

(2 https://github.com/NREL/GEOPHIRES-X/pull/187/files files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/NREL/GEOPHIRES-X/pull/187 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AWGVYT2K3KQWHS57MCJHD7TY6VOORAVCNFSM6AAAAABGTLOUTKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGI2TOMRYGA4TEMY . You are receiving this because your review was requested. https://github.com/notifications/beacon/AWGVYTYYHHRAKGXHGGONLG3Y6VOORA5CNFSM6AAAAABGTLOUTKWGG33NNVSW45C7OR4XAZNFJFZXG5LFVJRW63LNMVXHIX3JMTHINC27TM.gif Message ID: @. @.> >

softwareengineerprogrammer commented 2 months ago

I don’t see the fix… maybe there is an update I have to wait for in order to see it in Production?

@malcolm-dsider correct, this won't take effect until the PR is merged.

softwareengineerprogrammer commented 2 months ago

Confirmed docs at https://nrel.github.io/GEOPHIRES-X/parameters.html#economics are rendered correctly.