search

NREL / GEOPHIRES-X

MIT License
26 stars 21 forks source link

PR 185 Cleanup #193

Closed softwareengineerprogrammer closed 2 months ago

softwareengineerprogrammer commented 2 months ago

Follow-up from https://github.com/NREL/GEOPHIRES-X/pull/185 (self-reviewed in https://github.com/softwareengineerprogrammer/GEOPHIRES-X/pull/22)

  1. Calculate lithostatic_pressure as an overridden class method in CylindricalReservoir instead of passing parameters from WellBores for less code duplication and better consistency; plus other related code cleanup
  2. Unit tests for lithostatic pressure calculation
  3. More user-friendly message when MC fails
  4. Work-in-progress (skipped for now) Unit test for https://github.com/NREL/GEOPHIRES-X/issues/192