search

NREL / GEOPHIRES-X

MIT License
26 stars 21 forks source link

Verify lithostatic vs hydrostatic pressure to determine water properties #195

Closed kfbeckers closed 1 month ago

kfbeckers commented 2 months ago

Check which pressure is used for calculating water thermo-physical properties

softwareengineerprogrammer commented 1 month ago

See relevant previous discussion/work: https://github.com/NREL/GEOPHIRES-X/issues/118?title=Calculate+vapor_pressure_water_kPa+with+pressure+input

softwareengineerprogrammer commented 1 month ago

@kfbeckers or @malcolm-dsider can this be considered resolved by https://github.com/NREL/GEOPHIRES-X/pull/217?

kfbeckers commented 1 month ago

@kfbeckers or @malcolm-dsider can this be considered resolved by #217?

I would say yes. We are using hydrostatic pressure now for water properties so this issue is resolved I think.