search

NREL / GEOPHIRES-X

MIT License
26 stars 21 forks source link

is FCR being used correctly? #206

Closed malcolm-dsider closed 1 month ago

malcolm-dsider commented 1 month ago

A user reports that the fixed charge rate does not seem to function properly for some sensitivity analyses of EGS scenarios.

softwareengineerprogrammer commented 1 month ago

Note: we had a question about FCR in the past, for which we wrote an answer that is pending official incorporation into documentation: https://github.com/NREL/GEOPHIRES-X/issues/127. It's possible this FAQ is relevant to the user's report; but we can also investigate this by adding some tests for FCR functionality with or without further input from them.

malcolm-dsider commented 1 month ago

The report stated that changing the FCR did not change the LCOE for EGS models.

Our benchmark for EGS models with an FCR economic model is example_1. The default value for FCR is 0.05, which produces an LCOE of 9.65 cents/kWh.

If I change the FCR to an unrealistically low number, like 0.0001, I get an LCOE of 3.33 cents/kWh.

If I change the FCR to an unrealistically high number, like 0.8, I get an LCOE of 104.75 cents/kWh.

It seems that GEOPHIRES is producing reasonable answers for the edge cases without crashing, so I think we have the correct behavior. We can mark this as “not a bug.” The edge cases seem stable and reasonable, so perhaps we don’t need to add additional testing.

From: Jonathan Pezzino @.> Sent: Wednesday, May 8, 2024 1:00 PM To: NREL/GEOPHIRES-X @.> Cc: Malcolm Ross @.>; Author @.> Subject: Re: [NREL/GEOPHIRES-X] is FCR being used correctly? (Issue #206)

Note: we had a question about FCR in the past, for which we wrote an answer that is pending official incorporation into documentation: #127 https://github.com/NREL/GEOPHIRES-X/issues/127 . It's possible this FAQ is relevant to the user's report; but we can also investigate this by adding some tests for FCR functionality with or without further input from them.

— Reply to this email directly, view it on GitHub https://github.com/NREL/GEOPHIRES-X/issues/206#issuecomment-2101115776 , or unsubscribe https://github.com/notifications/unsubscribe-auth/AWGVYTZUK6HWANCXNSYL4LLZBJRZ3AVCNFSM6AAAAABHNIUU2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBRGEYTKNZXGY . You are receiving this because you authored the thread. https://github.com/notifications/beacon/AWGVYT43BT2YXC44KNRKVETZBJRZ3A5CNFSM6AAAAABHNIUU2CWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTT5HR5YA.gif Message ID: @. @.> >