search

NREL / GEOPHIRES-X

MIT License
26 stars 21 forks source link

Miscellaneous fixes & improvements [v3.4.29] #215

Closed softwareengineerprogrammer closed 1 month ago

softwareengineerprogrammer commented 1 month ago

Fixes:

  1. https://github.com/NREL/GEOPHIRES-X/issues/174
  2. https://github.com/NREL/GEOPHIRES-X/issues/139

Improvements:

  1. https://github.com/softwareengineerprogrammer/GEOPHIRES-X/pull/24
  2. https://github.com/NREL/GEOPHIRES-X/issues/188
  3. https://github.com/NREL/GEOPHIRES-X/issues/206
  4. https://github.com/NREL/GEOPHIRES-X/pull/204#discussion_r1594394709
softwareengineerprogrammer commented 1 month ago

Looks like we are dropping build date from the output.

Correct - relevant tracking issue - https://github.com/NREL/GEOPHIRES-X/issues/139. Having taken another look at this, I concluded that the build date as output should be removed because it is objectively incorrect, actively misleading, and redundant with the combination of version and simulation date. For example - if the GEOPHIRES Version in a case report is 3.4.24, the "build date"* can be found at https://github.com/NREL/GEOPHIRES-X/releases/tag/v3.4.24 as 2024-04-11.

We could potentially re-add build date in the future via some kind of git history introspection if we decide it's worthwhile.

* Note also that "build" isn't really the right technical term either in this context IMO; "release" is probably more appropriate