RHammond2 commented 3 weeks ago

Patch: Update ProFAST requirement to PyPI listing

This PR removes the ProFAST git installation instructions, and lists the PyPI version in pyproject.toml.

Related issue

N/A

Impacted areas of the software

Removes the git ProFAST installation step from the following:
- README.md
- docs/install.md
- .github/workflows/ci.yml
- environment.yml
Adds the ProFAST PyPI listing to: pyproject.toml
Bumps the version in greenheart/__init__.py
tests/greenheart/test_hydrogen/test_h2_transport/test_h2_compressor.py:test_system_power_report uses pytest.approx to handle a failing test whose error differs by 8.27e-15% from the set value.
CHANGELOG.md has been updated for this patch and some missing past additions.

Additional supporting information

N/A

Test results, if applicable

One test failed with the result differing by 8.27e-15%, so I've updated it to use pytest.approx with default precision.

johnjasa commented 3 weeks ago

This is cool, thanks for the updates, Rob! I like the completeness.

We've had some changes to develop since the last release; do you want to merge this PR into main then back into develop, or grab develop's changes into this PR, or how do you want to proceed?

RHammond2 commented 3 weeks ago

@johnjasa if develop is about ready for a v0.1.3 as it is, then I can switch the base branch to develop, and the changelog can be updated more completely. Does that make sense?

johnjasa commented 3 weeks ago

Got it, yes let's switch to develop as the main other changes are also from reducing dependencies; removing electrolyzer and pip-installing ProFAST go hand-in-hand imo.

For the changelog, just adding these bullets to what you have would be good with me:

Removed dependence on external electrolyzer repo
Updated CI to use conda

NREL / GreenHEART