Enable CustomFinancialModel to get costs from PySAM

NREL / HOPP

https://hopp.readthedocs.io/

BSD 3-Clause "New" or "Revised" License

23 stars 46 forks source link

Enable CustomFinancialModel to get costs from PySAM #264

Open jaredthomas68 opened 10 months ago

jaredthomas68 commented 10 months ago

The financial model must be consistent across all technologies, but the wave energy requires the CustomFinancialModel class. HOPP uses the SingleOwner financial model to get PV (and other tech) costs. Thus, when using CustomFinancialModel the PV costs are not available.

We need to update HOPP such that PySAM costs can be accessed when using the CustomFinancialModel class. This could be possibly done by inheriting from the SingleOwner class or by creating methods in CustomFinancialModel to access PySAM costs.

kbrunik commented 9 months ago

Addressed in https://github.com/jaredthomas68/HOPP/pull/2

Creates new method set_overnight_capital_cost() in PowerSource to add technology costs.
Modified set_overnight_capital_cost() for Battery class, includes energy_capital_cost and power_capital_cost

Ideally in the future we can pull ATB costs directly from an API or other method. There is an outdated ATB json in HOPP (2020), could potential update to most recent ATB but not sure if that's the best path.

bayc commented 2 weeks ago

@jaredthomas68 Can we close this if it was addressed in the PR mentioned above?