NOTE: Similar capabilities were achieved in #289. This PR was not merged due to issues with tests failing, most likely due to unintended effects within the custom financial model.
Expand custom_financial_model to use a more well-defined dictionary and utilize defaults for the default_fin_config
This PR updates custom_financial_model to use a dictionary that separates the configuration dictionary by technology. It also established default dictionaries within the code so the user does not have to supply the default_fin_config.yaml explicitly. This simplifies setup and more easily enables a user to update specific parts of the default financial configuration for different technologies.
Related issue
284
Impacted areas of the software
Mostly custom_financial_model.py
Small updates in each of the technologies
Tests
Additional supporting information
This method still requires the user to specify a dictionary to use the custom financial model. In the inputs files, where we don't want to specify the input explicitly or point to a yaml file, I have included an empty dictionary. This could be changed if we updated the logic in each of the technologies for when the custom financial model is used. I think it would be good to update this to use a flag, but is worth more discussion.
NOTE: Similar capabilities were achieved in #289. This PR was not merged due to issues with tests failing, most likely due to unintended effects within the custom financial model.
Expand
custom_financial_modelto use a more well-defined dictionary and utilize defaults for thedefault_fin_configThis PR updates
custom_financial_modelto use a dictionary that separates the configuration dictionary by technology. It also established default dictionaries within the code so the user does not have to supply thedefault_fin_config.yamlexplicitly. This simplifies setup and more easily enables a user to update specific parts of the default financial configuration for different technologies.Related issue
284
Impacted areas of the software
Mostly
custom_financial_model.pySmall updates in each of the technologies TestsAdditional supporting information
This method still requires the user to specify a dictionary to use the custom financial model. In the inputs files, where we don't want to specify the input explicitly or point to a yaml file, I have included an empty dictionary. This could be changed if we updated the logic in each of the technologies for when the custom financial model is used. I think it would be good to update this to use a flag, but is worth more discussion.
Test results, if applicable
Tests are not passing.