MartySchwarz
commented
2 years ago @Levie, @.***>
Happy to hop on a call. We can remove that line that references GVEA BESS, it was a quick fix to plot something right before a meeting.
From: Daniel Levie @.> Date: Monday, October 3, 2022 at 12:52 PM To: NREL/Marmot @.> Cc: Schwarz, Marty @.>, Mention @.> Subject: Re: [NREL/Marmot] Add battery entries to plexos_properties (PR #46)
CAUTION: This email originated from outside of NREL. Do not click links or open attachments unless you recognize the sender and know the content is safe.
@daniellevie commented on this pull request.
@MartySchwarzhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FMartySchwarz&data=05%7C01%7CMarty.Schwarz%40nrel.gov%7Cbb363241824a4598176508daa5707331%7Ca0f29d7e28cd4f5484427885aee7c080%7C0%7C0%7C638004199656198318%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=%2FcKMSnRktur%2BXOXSNbY4OZL76PJu3mBr9xGV78%2BFiMg%3D&reserved=0 we should probably have a call to quickly review before merging.
Some pieces of code I'm unsure of
@@ -413,13 +407,34 @@ def gen_stack(
else:
vre_gen_cat = self.gen_categories.vre-
Insert battery generation.
-
stacked_bat_gen : pd.DataFrame = self[
-
f"batterie_Generation{data_resolution}"
-
].get(scenario)
-
if stacked_bat_gen.empty is True:
-
logger.info("No Battery generation in selected Date Range")
-
else:
-
if shift_leapday:
-
stacked_bat_gen = self.adjust_for_leapday(stacked_bat_gen)
-
stacked_bat_gen = stacked_bat_gen.xs(
-
'GVEA BESS', level='battery_name'
'GVEA BESS' may cause issues if this battery_name is not in your results. What exactly are you trying to do here?
— Reply to this email directly, view it on GitHubhttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FNREL%2FMarmot%2Fpull%2F46%23pullrequestreview-1128861994&data=05%7C01%7CMarty.Schwarz%40nrel.gov%7Cbb363241824a4598176508daa5707331%7Ca0f29d7e28cd4f5484427885aee7c080%7C0%7C0%7C638004199656198318%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=MKZLXiaEXV9%2FZ5RQekKoDjJS3N8nLdkzOLbYQJ0hrJo%3D&reserved=0, or unsubscribehttps://gcc02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMYPJWBWPRD6G4UW4F6ZWBTWBMTPRANCNFSM56CTSLSQ&data=05%7C01%7CMarty.Schwarz%40nrel.gov%7Cbb363241824a4598176508daa5707331%7Ca0f29d7e28cd4f5484427885aee7c080%7C0%7C0%7C638004199656198318%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=HWzwQEeIrL0lbOzTfrNCQQbR53AD4vGTA2NWv%2FEDRDg%3D&reserved=0. You are receiving this because you were mentioned.Message ID: @.***>
daniellevie
Subtract batterie_load from ExtraPropertiesPLEXOS.demand() before merging.