NREL / MoorPy

BSD 3-Clause "New" or "Revised" License
31 stars 16 forks source link

Volume Unit Fix and Numpy Version fix #21

Closed Yuksel-Rudy closed 4 months ago

Yuksel-Rudy commented 5 months ago

Purpose

In the sample.txt file, the volume unit was fixed to (m^3) instead of (mˆ3), this generated a problem in running the example for MacOS users. In this pull request, I also adjusted the unload method in the system.py so that when users create a MoorDyn file, it will have the correct symbol for the volume unit. Additionally, the new numpy version has removed some features that made moorpy obsolete. One easy fix for now is to force the installation of an older numpy version in the environment.yml file. Explain the goal of this pull request. If it addresses an existing issue be sure to link to it. Describe the big picture of your changes here, perhaps using a bullet list if multiple changes are done to accomplish a single goal. If it accomplishes multiple goals, it may be best to create separate PR's for each.

Type of change

Testing

Explain the steps needed to test the new code to verify that it does indeed address the issue and produce the expected behavior.

Checklist

Put an x in the boxes that apply.

mattEhall commented 4 months ago

Has been pulled in from the later pull request.