NREL / NEB-Tool

A user friendly, graphical, open-source application (Web/Mac/Windows) of the multiple benefits framework for non-energy benefits, incorporating additional aspects to make the tool effective for use in the United States.
Other
1 stars 2 forks source link

Assessment Fixes #207

Closed koay9f closed 1 week ago

koay9f commented 2 months ago

Name changes & Enum change detailed in other issue Equipment Connection in other issue

1 - Energy Use needs to be dynamic based on Assessment Type. Might have multiple types of energy use.

image.png

2- Something in Energy Opportunities & NEBS to show what industrial system the assessment is for break into separate issue if needed

image.png
RLiNREL commented 2 months ago

After discussion with @koay9f , the workflow is,

  1. The user chooses an assessment type
  2. Based on the assessment type, offer a list of associated utility types to choose from. Note that ONE assessment type can be associated with MULTIPLE utility types at the same time eventually (some unit conversions issues and impact to the NEB calculations). But for now, it is ONE to ONE relationship/ one assessment type associated with one utility types. The complexity of associations with multiple utilities at the same time will be addressed in other issue.
  3. Based on the utility type, offer a list of units to choose from.
koay9f commented 1 month ago

It looks like there is a default selection for Utility Type happening when you change the Assessment type.
It would be good if Process Heating & Steam's default was Natural gas. If you have water, it puts you on water (excellent) and that is all you can select. Conversely, when you have an energy, you cannot select water as your utility type. If you go from pump to PH or steam, it stays on electricity, but if you go from water to PH or steam it DOES select natural gas.

This morning we talked about having this be checkboxes I think. If we are going through with that, then use the above as defaults (Steam & PH should be "Natural Gas" only; Treasure Hunt should be electricity and NG). Also make a note in this issue and I will make note when reviewing.

Water's default unit should be kgal Natural gas's and other fuel's default unit should be MMBTU

I forgot we had them as options, but ... Steam should have the utility type option: "Steam" (with units: klb (default), lb, kg, tonne + energy units) Compressed air have the utility type option: "Compressed Air" (with units: kscf (default), m^3)

point 2 is good

koay9f commented 1 month ago

Also - I just noticed my selection for the unit in assessment isn't saving when I navigate away from the page

RLiNREL commented 1 month ago

Changes to make:

RLiNREL commented 1 month ago
Two tables to capture the logics and relationships: Assessment Type Utility Type Default
Pump Electricity Electricity
Fan Electricity Electricity
Process heating Natural Gas Natural Gas
Steam Natural Gas Natural Gas
Compressed Air Electricity Electricity
Water Water Water
Treasure Hunt Electricity, Natural Gas Electricity
Other Electricity, Natural Gas, Other Fuels, Water, Waste Water, Steam, Compressed Air Electricity
Utility Type Energy Unit Options Default
Electricity ENERGY kWh
Natural Gas ENERGY MMBtu
Other Fuels ENERGY MMBtu
Water VOLUMELIQUID kGal
Waste Water VOLUMELQUID kGal
Steam STEAM:klb, lb, kg, tonne, ENERGY klb
Compressed Air VOLUMEGAS kscf
koay9f commented 3 weeks ago

2 things:

1 - Like equipment

image.png

2 - the energy unit through out the assessment needs to match the specified energy (or dropdown that's default matches the specified)

Also, to account for "Water" maybe have Annual Energy Use and Annual Energy Savings become Annual Utility Use and Annual Utility Savings (at least when water, if not always)

image.png image.png
RLiNREL commented 3 weeks ago
  1. updated.
  2. fixed.

Also, to account for "Water" maybe have Annual Energy Use and Annual Energy Savings become Annual Utility Use and Annual Utility Savings (at least when water, if not always)

The utility settings are updated to be similar to pre-assessment page, i.e., allow multiple utility types under single assessment. Thus, the wording change for Water may not apply, for example, if both Water and Electricity are both chosen, we will just call it Annual Energy Use and Annual Energy Savings. However, if @koay9f feel the wording change is necessary when Water is the only utility chosen, we can add that logic in. Thanks

koay9f commented 2 weeks ago

since we decided to skip water for now, I think we can leave that...

Utility type: Steam should also have the Steam Utility Compressed air should also have the Compressed Air Utility

Savings unit matching: looks good for Energy Efficiency Opps page, but still not right on Details page.

image.png
RLiNREL commented 2 weeks ago

since we decided to skip water for now, I think we can leave that...

Created a new issue #289 to get back on water/waste water unit systems

Steam should also have the Steam Utility Compressed air should also have the Compressed Air Utility

Added, but the existing assessments are not updated (need manually add the new utility to exported json and re-import)

Savings unit matching

Updated savings unit is changing based on the number of included utilities