search

NREL / NEB-Tool

A user friendly, graphical, open-source application (Web/Mac/Windows) of the multiple benefits framework for non-energy benefits, incorporating additional aspects to make the tool effective for use in the United States.
Other
1 stars 2 forks source link

Initial application setup #7

Closed rmroot closed 11 months ago

rmroot commented 11 months ago

connects #1

Initial application setup:

Added static navbar and welcome page. Added initial API for communication between Angular and Electron through Electron Service Updated README with instructions for running application

jordanperr commented 11 months ago

Thank you, mark, for uploading the first draft. This is a great starting point for us! I was able to run everything but the tests, which require the ng command line tool. I'll revisit this at a later time.

My comments, in addition to the inline comments.

Deprecation warnings:

rmroot commented 11 months ago

Thank you, mark, for uploading the first draft. This is a great starting point for us! I was able to run everything but the tests, which require the ng command line tool. I'll revisit this at a later time.

My comments, in addition to the inline comments.

  • [ ] I made a slight changes the readme (as discussed) creating a dependency section and noting our NPM version is 20.9 LTS and updating a path.
  • [ ] Warning when building (npm run build and build-prod) "bundle initial exceeded maximum budget. Budget 500.00 kB was not met by 12.93 kB with a total of 512.93 kB." Do we care about this?
  • [ ] Various deprecation warnings when running npm install (see below) Do we care about this?

Deprecation warnings:

  • npm WARN deprecated @babel/plugin-proposal-unicode-property-regex@7.18.6: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-unicode-property-regex instead.
  • npm WARN deprecated @babel/plugin-proposal-async-generator-functions@7.20.7: This proposal has been merged to the ECMAScript standard and thus this plugin is no longer maintained. Please use @babel/plugin-transform-async-generator-functions instead.
  • npm WARN deprecated w3c-hr-time@1.0.2: Use your platform's native performance.now() and performance.timeOrigin.
  • npm WARN deprecated @wessberg/ts-evaluator@0.0.27: this package has been renamed to ts-evaluator. Please install ts-evaluator instead

I have addressed all of the comments with the exception of adding how to install the angular CLI to the README. Still need to get to that.

I did remove codesigning related things for the mac installer in package.json at this time because we don't have that in place and it's a whole beast in itself.

Don't believe we care about the "Budget" we can just bump it up. And I am not concerned with the deprecation warnings at this time.