Closed RHammond2 closed 1 year ago
Attention: 49 lines
in your changes are missing coverage. Please review.
Comparison is base (
c721ef5
) 65.76% compared to head (f91d942
) 65.48%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@jordanperr for #229 I think for me the ask is still a bit vague and not remotely possible if an analysis class requires a PlantData
object for initialization, so if you could provide more details on the what then we might be able to get something in there, but as-is I would close it and request a new issue with more specifics. Similarly, the schema are provide through openoa.schema.metadata.ANALYSIS_REQUIREMENTS
, so a user could just import that and use it as needed.
However, if we're thinking of enabling bringing a custom validation set, then that's maybe a separate idea, though, and would enable additional workflows like a user-defined analysis class/method, which is pretty useful for more customized analysis workflows.
This is the final cleanup for take care of the last remaining threads in the issues.
Closes #125
Closes #229
Closes #214