Closed RHammond2 closed 9 months ago
Attention: Patch coverage is 66.66667%
with 2 lines
in your changes missing coverage. Please review.
Project coverage is 72.46%. Comparing base (
c0485c8
) to head (c67bb8d
). Report is 16 commits behind head on develop.
Files with missing lines | Patch % | Lines |
---|---|---|
openoa/utils/timeseries.py | 60.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR updates the examples after the last batch of pull requests to ensure that everything is in working order. The following issues were identified and fixed:
MonteCarloAEP.time_resolution
's default is now set to "MS", not "ME" to restore expected behavior in the examples.plant.py::frequency_validator
no longer attempts to convert monthly resolution offset strings to atimedelta
as this incorrectly returned minutes prior to Pandas 2.0, but with 2.2 we get etiher a failure ("ME") or milliseconds ("MS"). As such, "MS" and "ME" are left as-is and not converted at all, leavingtimeseries.py::offset_to_seconds
method intact.timeseries.py::gap_fill_data_frame
catches a new error resulting from a change in the Pandas API that no longer allows column sorting when the index has the same name. To resolve this issue, the column name is temporarily renamed to perform the sort, but still returns back a dataframe with the original index and column naming conventions.