Require VentilationFan `UsedForFoo` elements - Githubissues

NREL / OpenStudio-ERI

Energy Rating Index (ERI) calculation via OpenStudio/EnergyPlus.

Other

18 stars 8 forks source link

Require VentilationFan `UsedForFoo` elements #705

Closed shorowit closed 9 months ago

shorowit commented 9 months ago

Pull Request Description

Each VentilationFan must have one (and only one) UsedFor... element set to true.

Technically a breaking change, but all (?) software are probably already doing this. Just making sure.

Checklist

PR Author: Check these when they're done. Not all may apply. ~~strikethrough~~ and check any that do not apply.

PR Reviewer: Verify each has been completed.

[ ] OS-HPXML git subtree has been pulled
[ ] 301/ES rulesets and unit tests have been updated
[ ] 301validator.xml has been updated (reference EPvalidator.xml)
[ ] Workflow tests have been updated
[ ] Documentation has been updated
[ ] Changelog has been updated
[ ] openstudio tasks.rb update_measures has been run
[ ] No unexpected regression test changes on CI