NREL / OpenStudio-HPXML

Modeling of residential buildings in EnergyPlus using OpenStudio/HPXML.
Other
38 stars 12 forks source link

Storm doors #1005

Open shorowit opened 2 years ago

shorowit commented 2 years ago

Allow modeling of storm doors. We should probably implement https://github.com/hpxmlwg/hpxml/issues/277 first.

yzhou601 commented 2 years ago

@shorowit What is the current status of storm door schema change discussion? The current bool StormDoor element looks sufficient to the R-1 adjustment, but if StormDoor element is going to be refactored soon, it's ok to wait until that's in the place.

shorowit commented 2 years ago

@yzhou601 You could propose a HPXML PR that implements a new StormDoor element with child elements, like is suggested. Or we could update OS-HPXML to use the current element and update it again in the future when the element changes.

yzhou601 commented 2 years ago

@yzhou601 You could propose a HPXML PR that implements a new StormDoor element with child elements, like is suggested. Or we could update OS-HPXML to use the current element and update it again in the future when the element changes.

Sure, I will try proposing a new StormDoor element first, if it leads to more discussions we can use current element for now.