search

NREL / OpenStudio-PAT

The Parametric Analysis Tool (PAT) is part of the OpenStudio collection of software tools.
https://www.openstudio.net/
Other
27 stars 13 forks source link

new labs MeasureManager #267

Open kflemin opened 1 year ago

kflemin commented 1 year ago

PAT updates for new labs MeasureManager

now starting measure manager with the following command:

openstudio labs measure -s <port number>

Ready to merge when you want to use this new MeasureManager! works with openstudio starting with this version.

kbenne commented 1 year ago

@kflemin I made a change here that I think will get you an easy to parse message that indicates when the server is ready. The CI should produce a build that you can use to test soon.

kflemin commented 1 year ago

@kbenne, that change fixed the issue! everything looks good now I think! Note that I am keying off of "MeasureManager Ready" in the output, so let me know if that changes. Screen Shot 2023-09-28 at 9 47 27 AM

kbenne commented 1 year ago

Cool. We'll keep "MeasureManager Ready". I put that in there because I expected it would be easy for you to parse as it doesn't include any variable text like the hostname or the port. Thanks for working through this with me!

kbenne commented 1 year ago

Thank you @jmarrec for doing all of the heavy lifting on the OpenStudio side.

kflemin commented 1 year ago

thank you both!

wenyikuang commented 11 months ago

Hi all, since we are keeping use classic flag here, I don't think the pr is still valid?

kflemin commented 11 months ago

maybe let's leave it here until we decided to update from classic in the future?

jmarrec commented 11 months ago

Of course do what you please, but I'd still like to ask you consider switching as early as possible on dev in the release cycle so that you at least have some amount of people trying it out and reporting issues they may encounter, so we have plenty of time to calmy address whatever comes up (and not rush between release candidate and official)

Alternatively you can make a runtime setting (a bool toggle) to allow changing between classic and labs. That's what I've done on OpenStudio Application

kbenne commented 11 months ago

@jmarrec Kat has been voluntering her time so far.

@DavidGoldwasser I second what Julien is saying. It would be helpful to have this switch happening now while we are early in the release cycle.

kflemin commented 11 months ago

I totally agree @jmarrec!

DavidGoldwasser commented 11 months ago

It would be great if we can merge to develop in January. The Ruby 3.2 upgrade will also have impacts to PAT through Analysis Gem.

brianlball commented 4 months ago

@wenyikuang this is probably needed for 3.8.0?

DavidGoldwasser commented 2 days ago

@jmarrec we are working on first Rc for PAT for 3.9. I don't think we want to call labs anymore. Is this outdated. Do we still need parts of it. We want to use new C++ workflow not classic.

CC @kflemin @kbenne

jmarrec commented 1 day ago