search

NREL / OpenStudio-PAT

The Parametric Analysis Tool (PAT) is part of the OpenStudio collection of software tools.
https://www.openstudio.net/
Other
26 stars 12 forks source link

"Could not set argument" should show visible error in GUI #41

Open kflemin opened 6 years ago

kflemin commented 6 years ago

From @DavidGoldwasser on October 2, 2017 20:2

I hit this error in a workflow where I had full model as seed, and then had EE measures for both LPD reduction and night time lighting reduction. The arguments for the reduce night time lighting has a choice argument of all lighting defs in the model that are used by an instance. Using the seed model it can pick 'Office OpenOffice Lights Definition'. If that was passed in to the measure and was gone, the measure would gracefully fail and explain why, but it seems like the arguments section is run again with the updated model (post LPD reduction) and fails. I'm fine with it failing in this way, but it seems like there should be an error in the GUI for that measure step in the workflow. It isn't ideal for users to have to dig through the JSON file on the server to identify the reason for the cause.

[13:11:01.058692 ERROR] Could not set argument 'lights_def' to value 'Office OpenOffice Lights Definition'

screen shot 2017-10-02 at 1 39 31 pm

Copied from original issue: NREL/OpenStudio#2806

kflemin commented 6 years ago

From @DavidGoldwasser on October 2, 2017 20:16

For reference. Here is zip of the project. There is a separate issue for the first two datapoints failing, this one is more about showing an error for the expected failure of the last datapoint. https://github.com/NREL/OpenStudio-files/blob/master/Git%20Issue%20Files/issue2807.zip

@macumber, @kflemin, @asparke2 any thoughts on best solution. For now I guess it is just about better showing error to user. Eventually could let user type name or generate the values in GUI dynamically by running upstream measures. For now user would run upstream manually first and load as 'dummy' seed for this measure arg calculation.

kflemin commented 6 years ago

@DavidGoldwasser, I'm not sure I understand this completely, but it sounds like there is a failure during the analysis. Should it be a server issue? There's not much we can do in PAT unless we can do a check prior to running the analysis to detect this condition.

kflemin commented 6 years ago

@henryHorsey, this seems to be a server issue.

rwadhwa910 commented 3 years ago

The same issue is happening with one of my model where the PAT is not able to show which measure is failing, the other thing is if i go and see the out.osw file there are no failures for any measures which means the measure is not failing the model is failing in between two measures, there are no warning in any of the measure in the out .osw file.

PAT variable_notgetting_update

Capture

I feel the user should get to know why the model failed.

OS 3.1.0

PAT 3.1.0

DavidGoldwasser commented 3 years ago

@kbenne not sure if it is server. It may actually be workflow gem. I think something needs to be in the extended out.osw file from a run. Then PAT could read the error is there. Seems like instead of making new workflow steps that sits between measure, maybe this can be logged in the workflow step of the measure that is getting ready to run. Then nothing would change in PAT. @nllong and @henryHorsey any thoughts on that.