NREL / OpenStudio-measure-tester-gem

Other
3 stars 0 forks source link

If one measure class is contained by another then unit tests don't show correctly #24

Open DavidGoldwasser opened 6 years ago

DavidGoldwasser commented 6 years ago

@nllong and @macumber I'll send screenshot outside of repo, but example is demonstrated below.

If a directory has these measures with the classes below "MyOrigMeasure" will report with zero tests, even though it has tests. This only affects the main dashboard reporting. The minitest HTML file correctly shows the tests for all of the measures

ABC MyOrigMeasure MyOrigMeasureCopy XYZ

Te following actions fix the issue.

Before figuring this out I confirmed the measure test file name, test class name, and test names were unique between the original and copied measure. The measure was copied correctly where it didn't share UUID with the original.

DavidGoldwasser commented 4 years ago

@tijcolem I think this may be what we were hitting on aedg measure repo.

@nllong for reference, the displayed dashboard looks like all tests passed, but two failed tests were not visible. https://github.com/NREL/openstudio-aedg-gem/pull/6

See side by side screenshot below. Now that I see this I can fix the immediate issue with the pull request.

Screen Shot 2020-04-23 at 2 40 09 PM
nllong commented 4 years ago

Is this still an issue?

DavidGoldwasser commented 4 years ago

yes