search

NREL / OpenStudio-measure-tester-gem

Other
3 stars 0 forks source link

Support Ruby 2.5.5 #37

Closed nllong closed 4 years ago

nllong commented 4 years ago

@tijcolem Are you able to move this over to the NREL CI (and remove travis)?

tijcolem commented 4 years ago

I can push up a Jenkins job to this PR, and once that is good, we can remove the .travis file

nllong commented 4 years ago

Great, thanks tim!

Da: TJC notifications@github.com Risposta: NREL/OpenStudio-measure-tester-gem reply@reply.github.com Data: mercoledì 12 febbraio 2020 09:41 A: NREL/OpenStudio-measure-tester-gem OpenStudio-measure-tester-gem@noreply.github.com Cc: "Long, Nicholas" Nicholas.Long@nrel.gov, Author author@noreply.github.com Oggetto: Re: [NREL/OpenStudio-measure-tester-gem] Support Ruby 2.5.5 (#37)

I can push up a Jenkins job to this PR, and once that is good, we can remove the .travis file

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/NREL/OpenStudio-measure-tester-gem/pull/37?email_source=notifications&email_token=AAORVGWTPRW7SH3FXBXKJ7DRCQREVA5CNFSM4KTSDRH2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELRO77Q#issuecomment-585297918, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAORVGR6SMGLNBII7M36SELRCQREVANCNFSM4KTSDRHQ.

tijcolem commented 4 years ago

@nllong CI results are posted now. I am using 3.x openstudio container to run the job which has the default ubuntu:18.04 system ruby 2.5.1 which is compatible with OpenStudio embedded 2.5.5. Looks like rake task passed using bundler version ~> 2.1

If your good with this CI job, I'll remove the .travis files. We may need to check if any hooks are in place in GitHub for this repo and remove those are well.