search

NREL / OpenStudio-measure-tester-gem

Other
3 stars 0 forks source link

Support PV as valid upcase class name #5

Closed DavidGoldwasser closed 6 years ago

DavidGoldwasser commented 6 years ago

If we don't do this then I'll change the measure, but I thought we decided to add that to the list of acceptable measures.

Well, I see that currently there are two PV measures, and one of them uses "PV" while another uses "Pv" so whichever way we choose, I'll fix one measure or the other.

DavidGoldwasser commented 6 years ago

@nllong I'll wait to see what your preference is on this before doing anything.

nllong commented 6 years ago

upcased PV is the convention https://github.com/NREL/OpenStudio-measure-tester-gem/blob/master/lib/openstudio_measure_tester/core_ext.rb#L51